Skip to content

Update nav.php to use relative path hyperlinks#57

Closed
akbaig wants to merge 2 commits intoMichaelBelgium:masterfrom
akbaig:patch-3
Closed

Update nav.php to use relative path hyperlinks#57
akbaig wants to merge 2 commits intoMichaelBelgium:masterfrom
akbaig:patch-3

Conversation

@akbaig
Copy link
Contributor

@akbaig akbaig commented Feb 17, 2025

This pull request removes the dependency of placing the project at the root level of a website.

  1. Nav.php uses relative path for the hyperlinks
  2. Hyperlink paths are adjusted dynamically (depending upon where the module is called from, /index.php or logs/index.php)

Example:

www.website.com/something/index.php ✅ (Relative hyperlinks still work in this case)

@akbaig akbaig closed this by deleting the head repository Mar 14, 2025
@akbaig
Copy link
Contributor Author

akbaig commented Mar 21, 2025

@MichaelBelgium any thoughts on this?

Sorry, I didn't mean to close this PR. It was a side-effect of me deleting the fork.

@MichaelBelgium
Copy link
Owner

You might want to do a new PR then cuz if your fork is gone, i cant see the changes and test it out

@MichaelBelgium
Copy link
Owner

Or well, I can copy the changes cuz they're still visible here

@akbaig
Copy link
Contributor Author

akbaig commented Mar 23, 2025

Please see #58. I've replicated this PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants