Update nav.php to use relative path hyperlinks#57
Closed
akbaig wants to merge 2 commits intoMichaelBelgium:masterfrom
akbaig:patch-3
Closed
Update nav.php to use relative path hyperlinks#57akbaig wants to merge 2 commits intoMichaelBelgium:masterfrom akbaig:patch-3
akbaig wants to merge 2 commits intoMichaelBelgium:masterfrom
akbaig:patch-3
Conversation
Contributor
Author
|
@MichaelBelgium any thoughts on this? Sorry, I didn't mean to close this PR. It was a side-effect of me deleting the fork. |
Owner
|
You might want to do a new PR then cuz if your fork is gone, i cant see the changes and test it out |
Owner
|
Or well, I can copy the changes cuz they're still visible here |
Contributor
Author
|
Please see #58. I've replicated this PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the dependency of placing the project at the root level of a website.
Example:
www.website.com/something/index.php ✅ (Relative hyperlinks still work in this case)