Allow passing update options with caches#27
Open
Floriferous wants to merge 1 commit intoMeteor-Community-Packages:masterfrom
Open
Allow passing update options with caches#27Floriferous wants to merge 1 commit intoMeteor-Community-Packages:masterfrom
Floriferous wants to merge 1 commit intoMeteor-Community-Packages:masterfrom
Conversation
|
This pull request introduces 1 alert when merging 9e3c819 into d3fc1c0 - view on LGTM.com new alerts:
|
Member
|
@Floriferous could you please update with latest and take a look on the issue raised by LGTM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to fine-tune the collection updates made by denormalize.
In our case, we use the option
getAutoValues: falseandvalide: false, to avoid having caches trigger our simple schema autovalues.The main one being our
updatedAtdates, because of this package they never really meant anything, because writing on another collection, would trigger a cache in the concerned collection and update itsupdatedAtfield.Care should be taken if you need the cache in one of your autoValues, our internal policy is that we should never create such an autoValue :)