Skip to content

Docs/registry and ontology fixes #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coodos merged 2 commits into from
Jan 30, 2026
Merged

Docs/registry and ontology fixes #759

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a944efc
docs: address comments on registry
coodos Jan 30, 2026
77a7f10
Update docs/docs/Infrastructure/Registry.md
coodos Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/docs/Infrastructure/Registry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ The Registry is a core W3DS service that provides W3ID-based service discovery,

The Registry enables clients and services to:

- **Resolve W3IDs** to service endpoints (eVault URIs, platform URLs)
- **Resolve eNames** to service endpoints (eVault URIs, platform URLs)
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent terminology: eNames vs W3IDs.

The change introduces "eNames" here, but the rest of the document continues to use "W3IDs" extensively (lines 7, 59, 61, 63, 77, 141, 149, 157). This inconsistency may confuse readers about whether these are the same concept or different identifiers.

Either revert this change to maintain "W3IDs" throughout, or update all references in the document to use "eNames" consistently.

📝 Option 1: Revert to maintain consistency with rest of document 
-- **Resolve eNames** to service endpoints (eVault URIs, platform URLs)
+- **Resolve W3IDs** to service endpoints (eVault URIs, platform URLs)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- **Resolve eNames** to service endpoints (eVault URIs, platform URLs)
- **Resolve W3IDs** to service endpoints (eVault URIs, platform URLs)
🤖 Prompt for AI Agents 
In `@docs/docs/Infrastructure/Registry.md` at line 13, The documentation uses
"W3IDs" elsewhere but the diff changed a single instance to "eNames" ("Resolve
eNames"); make terminology consistent by either reverting this change back to
"Resolve W3IDs" or systematically replacing all occurrences of "W3IDs" with
"eNames" across the document; update the line containing "Resolve eNames" and
then run a global search for "W3IDs" (and "eNames") in this file to ensure a
single chosen term is used consistently (update any headings, bullets, and
references such as the instances at lines referenced in the review).

Copy link
Contributor Author

@coodos coodos Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nack, eName == W3ID with @ prefix, which is globally resolvable

Copy link
Contributor

@coderabbitai coderabbitai bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coodos, thank you for the clarification! I understand now—eNames are W3IDs with the @ prefix, so the change to "Resolve eNames" is more precise for the Registry's resolution functionality. My suggestion to revert was incorrect.

✏️ Learnings added 
Learnt from: coodos
Repo: MetaState-Prototype-Project/prototype PR: 759
File: docs/docs/Infrastructure/Registry.md:13-13
Timestamp: 2026-01-30T20:36:08.155Z
Learning: In the MetaState-Prototype-Project/prototype codebase: eName is a W3ID with the `@` prefix and is globally resolvable. The Registry resolves eNames (W3IDs with @ prefix) to service endpoints.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

- **Obtain entropy** as signed JWTs for use in provisioning and other operations
- **Verify tokens** via a public JWK endpoint
- **Verify tokens** using the JSON Web Key Set provided via public JWK endpoint

:::warning Remote Notary / Remote CA

Expand Down