Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 22, 2023

This is the release candidate for v8.0.0.

Added

  • Add wallet_watchAsset for ERC1155 (#272)

Changed

  • BREAKING: Minimum Node.js version is now 18 (#264)
  • Update to webpack 5 (#264)
  • Update eth_signTypedData_v4 example (#274)
  • Add transferFrom and approve to input address for ERC20 contract (#271)

@legobeat legobeat marked this pull request as ready for review November 22, 2023 01:08
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Nov 22, 2023

I have tested this locally with the MetaMask extension e2e test suite, and it all seems to be working correctly!

There was one test that failed, but it seems that the code-under-test is at fault here (the snap doing the signing is probably using a broken version of @metamask/eth-sig-utils). We'll have to update that test to use a snap that is not affected by that signing bug, or temporarily skip it until we can do that.

@Gudahtt Gudahtt merged commit f783801 into main Nov 22, 2023
@Gudahtt Gudahtt deleted the release/8.0.0 branch November 22, 2023 04:37
@Gudahtt
Copy link
Member

Gudahtt commented Nov 22, 2023

A new version of the package @metamask/test-dapp (8.0.0) was published at 2023-11-22T04:40:55.908Z from [redacted].
The shasum of this package is 72f64b18a6157400ef3a3901c35819883524a048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants