-
-
Notifications
You must be signed in to change notification settings - Fork 2
New Crowdin translations by Github Action #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
051bac3 to
c90f91f
Compare
| "messages": { | ||
| "recipientLabel": { | ||
| "message": "", | ||
| "message": "Recipient", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-English locale files populated with English text
Medium Severity
All non-English locale files (el.json, fr.json, hi.json, id.json, ja.json, ko.json, pt_BR.json, ru.json, tl.json, tr.json, vi.json) are being populated with English text instead of translations in their respective languages. Users with Greek, French, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, Turkish, or Vietnamese language preferences will see English UI text rather than properly localized content.
Additional Locations (2)
5036c0a to
3c846f3
Compare
jeffsmale90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a cursor comment on here indicating that the non-English language files are being populated with English.
Is this a configuration problem @MoMannn ?
3d02be0 to
3bef826
Compare
3bef826 to
453b3c1
Compare
453b3c1 to
c929101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| }, | ||
| "introGotItButton": { | ||
| "message": "", | ||
| "message": "Got it", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All non-English locales populated with English text
High Severity
Every locale file updated in this PR (el, fr, hi, id, ja, ko, pt_BR, ru, tl, tr, vi) contains identical English strings instead of actual translations. Comparing with properly translated files like de.json (which has "Empfänger" for "Recipient") and es_419.json (which has "Destinatario"), it's clear the Crowdin automation pushed the English source strings to all target locales. Users selecting any of these 10+ languages will see English instead of their chosen language.


Note
Low Risk
Static translation JSON updates only; no code paths, data handling, or security logic are modified.
Overview
Populates previously empty
messagefields inpackages/gator-permissions-snap/locales/*.json(e.g.,el,fr,hi,id,ja,ko,pt_BR,ru,tl,tr,vi) for the permissions request UI (labels, tooltips, validation errors, and intro copy).No logic changes; this is a content-only localization update (many strings remain in English, but are now non-empty).
Written by Cursor Bugbot for commit c929101. This will update automatically on new commits. Configure here.