Skip to content

Conversation

@metamaskbotv2
Copy link

@metamaskbotv2 metamaskbotv2 bot commented Jan 19, 2026

Note

Low Risk
Static translation JSON updates only; no code paths, data handling, or security logic are modified.

Overview
Populates previously empty message fields in packages/gator-permissions-snap/locales/*.json (e.g., el, fr, hi, id, ja, ko, pt_BR, ru, tl, tr, vi) for the permissions request UI (labels, tooltips, validation errors, and intro copy).

No logic changes; this is a content-only localization update (many strings remain in English, but are now non-empty).

Written by Cursor Bugbot for commit c929101. This will update automatically on new commits. Configure here.

@metamaskbotv2 metamaskbotv2 bot requested a review from a team as a code owner January 19, 2026 10:58
mj-kiwi
mj-kiwi previously approved these changes Jan 20, 2026
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 051bac3 to c90f91f Compare January 21, 2026 13:49
"messages": {
"recipientLabel": {
"message": "",
"message": "Recipient",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-English locale files populated with English text

Medium Severity

All non-English locale files (el.json, fr.json, hi.json, id.json, ja.json, ko.json, pt_BR.json, ru.json, tl.json, tr.json, vi.json) are being populated with English text instead of translations in their respective languages. Users with Greek, French, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, Turkish, or Vietnamese language preferences will see English UI text rather than properly localized content.

Additional Locations (2)

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 7 times, most recently from 5036c0a to 3c846f3 Compare January 28, 2026 01:40
Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a cursor comment on here indicating that the non-English language files are being populated with English.

Is this a configuration problem @MoMannn ?

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 3d02be0 to 3bef826 Compare January 28, 2026 20:40
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 3bef826 to 453b3c1 Compare February 10, 2026 09:56
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

},
"introGotItButton": {
"message": "",
"message": "Got it",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All non-English locales populated with English text

High Severity

Every locale file updated in this PR (el, fr, hi, id, ja, ko, pt_BR, ru, tl, tr, vi) contains identical English strings instead of actual translations. Comparing with properly translated files like de.json (which has "Empfänger" for "Recipient") and es_419.json (which has "Destinatario"), it's clear the Crowdin automation pushed the English source strings to all target locales. Users selecting any of these 10+ languages will see English instead of their chosen language.

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants