Feat: Unit Domain DoubleUnit, MergedUnit, Repository, Test 추가#24
Open
HyeW wants to merge 1 commit intofeat/issue-4/unit_entityfrom
Open
Feat: Unit Domain DoubleUnit, MergedUnit, Repository, Test 추가#24HyeW wants to merge 1 commit intofeat/issue-4/unit_entityfrom
HyeW wants to merge 1 commit intofeat/issue-4/unit_entityfrom
Conversation
유지보수를 위해 단방향 매핑을 기본으로 하여 코드를 작성합니다. DoubleUnit, MergedUnit과 MappedUnit은 Double과 Merged를 저장할 때 Mapped가 저장되는 것이 논리 상 맞아 양방향 매핑을 사용합니다.
Contributor
추후에 태그 관리(태그명 중복 검사, 최대 갯수 등등) 를 할 때 태그를 유닛 도메인 쪽에 포함하면 유닛 도메인의 책임이 많아질 것 같은데 어떻게 생각하시나요?
추가 배경: Single Unit 과 연관관계를 끊고 Double Unit, Merged Unit 과 생명주기를 같이 하는 MappedUnit 을 추가 현재 코드 상으로 봤을 때 원본 유닛(origin Unit) 과 연관관계를 맺고 있기 때문에 원본 파일 수정 시 mapped Unit 내용도 수정될 것 같은데 의도한 바가 맞나요? Mapped Unit 에 Double Unit 혹은 Merged Unit 하나만 매핑 -> 현재는 두 필드 전부 연관관(ManyToOne) 를 맺고 있는데 혹시 나중에 어떻게 조회할 예정이신가요? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 요약
변경 사항
클래스 다이어그램
참고 사항