Skip to content

fix: Use env exchange overrides for all scheduler messages#834

Merged
tangg555 merged 3 commits intodevfrom
fix/rabbitmq-exchange-override
Jan 7, 2026
Merged

fix: Use env exchange overrides for all scheduler messages#834
tangg555 merged 3 commits intodevfrom
fix/rabbitmq-exchange-override

Conversation

@glin93
Copy link
Contributor

@glin93 glin93 commented Jan 7, 2026

Summary

  • Apply MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME to all message types, regardless of environment or label.
  • Apply MEMSCHEDULER_RABBITMQ_EXCHANGE_TYPE when set.
  • Default routing key to "" when using env exchange override; allow override via MEMSCHEDULER_RABBITMQ_ROUTING_KEY.

Why

  • Ensures consistent routing when an exchange name is explicitly configured via env.
  • Removes label-scoped behavior that prevented non‑cloud messages from using the configured exchange.
  • Matches deployment reality where cloud/non‑cloud are on isolated infrastructure.

Changes

  • src/memos/mem_scheduler/webservice_modules/rabbitmq_service.py: env overrides now apply to all messages; routing key default behavior updated; exchange type env override applied during initialization.

@glin93 glin93 requested review from lijicode and tangg555 January 7, 2026 11:36
@tangg555 tangg555 merged commit 0e41b64 into dev Jan 7, 2026
16 checks passed
@glin93 glin93 deleted the fix/rabbitmq-exchange-override branch January 12, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments