fix: [PrefEval Evaluation] propagate --lib and --version arguments in search and response modes#780
Merged
CaralHsi merged 2 commits intoMemTensor:devfrom Jan 4, 2026
Conversation
… search and response modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Fixed a bug in the run_prefeval_eval.sh script where the
--liband--versionarguments were not being propagated to the Python scripts (pref_*.py) during the search and response modes.Previously, these arguments were only passed during the add mode. This caused the scripts to fallback to default values (e.g.,
lib="supermemory",version="0929-1") in subsequent steps, leading to incorrect file path resolutions or execution errors when non-default configurations were used. This change ensures consistent argument passing across all pipeline stages.Fix: #764
Docs Issue/PR: N/A
Reviewer: @fridayL @CaralHsi
Checklist: