-
Notifications
You must be signed in to change notification settings - Fork 520
fix: update deprecated APIs for chonkie v1.4.0 and qdrant-client v1.16.0 #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fridayL
merged 4 commits into
MemTensor:dev
from
zhixiangxue:fix/update-deprecated-apis
Dec 31, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ba37a5a
fix: update deprecated APIs and dependency versions
zhixiangxue f07032d
feat: add chonkie API version compatibility
zhixiangxue b5411af
chore: update poetry.lock for chonkie version compatibility
zhixiangxue e66369f
Merge branch 'dev' into fix/update-deprecated-apis
fridayL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think can not make direct changes package version , because our production environment uses chonkie >=1.0.7 and chonkie <1.4.0 versions. Changing the code and version requirements means the old environment will break , causing production system errors.
My suggestion is to add some version compatibility , check the chonkie version first and then add appropriate parameters.
Although this makes the code redundant, the system needs a transitional version.
我觉得这里不可以直接进行更改,因为我们内部的线上环境是使用的chonkie >=1.0.7 and chonkie <1.4.0版本,代码以及版本更改意味着老的环境会立即失效导致线上系统报错
我的建议是做一些版本兼容,或者判断一下版本然后传参数,虽然这样代码很冗余,但系统需要有个过渡版本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified as suggested with try-except for version compatibility:
Try new API (v1.4.0+) first, fallback to legacy API on failure
Reverted pyproject.toml chonkie version to >=1.0.7,<2.0.0 for production compatibility
Code pushed, please review 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice

but code check error
just Run
poetry lockto fix the lock file before commit codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done~