fix: sanitize generated room item HTML id to remove unsupported characters (including dots) - MEED-10200 - Meeds-io/meeds#4028#489
Merged
hakermi merged 1 commit intofeature/maintenancefrom Feb 17, 2026
Conversation
…cters (including dots) - MEED-10200 - Meeds-io/meeds#4028 Prior to this change, the generated HTML id could contain dots and other non-alphanumeric characters coming from spaceId or dmMemberId. Although dots are technically valid in HTML ids, they cause issues when used in CSS selectors (requiring escaping) and can lead to unexpected behavior in querySelector usage. This change restricts the id to [A-Za-z0-9_-] only and replaces any other character with an underscore to ensure safe and predictable DOM, CSS, and JavaScript usage.
|
ahamdi
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the generated HTML id could contain dots and other non-alphanumeric characters coming from spaceId or dmMemberId.
Although dots are technically valid in HTML ids, they cause issues when used in CSS selectors (requiring escaping) and can lead to unexpected behavior in querySelector usage.
This change restricts the id to [A-Za-z0-9_-] only and replaces any other character with an underscore to ensure safe and predictable DOM, CSS, and JavaScript usage.