fix: sanitize room item IDs to ensure valid HTML - MEED-10200 - Meeds-io/meeds#4028#488
Merged
hakermi merged 1 commit intofeature/maintenancefrom Feb 13, 2026
Merged
fix: sanitize room item IDs to ensure valid HTML - MEED-10200 - Meeds-io/meeds#4028#488hakermi merged 1 commit intofeature/maintenancefrom
hakermi merged 1 commit intofeature/maintenancefrom
Conversation
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
02272c9 to
f348c86
Compare
…-io/meeds#4028 prior to this change, the `roomItemTagId()` function could generate invalid HTML IDs if `spaceId` or `dmMemberId` contained characters like '@', spaces, or other special symbols. This caused issues when using these IDs in the DOM. This PR replaces all invalid HTML ID characters with underscores (`_`), to ensure valid HTML tag ID.
|
ahamdi
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior to this change, the
roomItemTagId()function could generate invalid HTML IDs ifspaceIdordmMemberIdcontained characters like '@', spaces, or other special symbols. This caused issues when using these IDs in the DOM.This PR replaces all invalid HTML ID characters with underscores (
_), to ensure valid HTML tag ID.