Skip to content

date fields of GS1 barcodes should consider the timezone offset #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoolandes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

date fields of GS1 barcodes should consider the timezone offset #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions spec/BarcodeParserSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe("A parsed GS1 barcode", () => {
expect(result.parsedCodeItems).toEqual(jasmine.arrayContaining([jasmine.objectContaining({
ai: "17",
dataTitle: "USE BY OR EXPIRY",
data: new Date(2015, 0, 29, 0, 0, 0, 0)
data: new Date('2015-01-29')
})]));
});

Expand Down Expand Up @@ -93,7 +93,16 @@ describe("A parsed GS1 barcode", () => {
expect(result.parsedCodeItems).toEqual(jasmine.arrayContaining([jasmine.objectContaining({
ai: "17",
dataTitle: "USE BY OR EXPIRY",
data: new Date(2019, 4, 31, 0, 0, 0, 0)
data: new Date('2019-05-31')
})]));
});
});

describe("Date fields of a parsed GS1 barcode", () => {
it("should consider the timezone offset", () => {
const barcode = "15230300";
const result = parseBarcode(barcode);

expect(result.parsedCodeItems[0].data.toISOString()).toEqual('2023-03-31T00:00:00.000Z');
});
});
4 changes: 2 additions & 2 deletions src/BarcodeParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const parseBarcode = (function () {
break;
case "D":
this.data = new Date();
this.data.setHours(0, 0, 0, 0);
this.data.setUTCHours(0, 0, 0, 0);
break;
default:
this.data = "";
Expand Down Expand Up @@ -218,7 +218,7 @@ const parseBarcode = (function () {
monthAsNumber--;
}

elementToReturn.data.setFullYear(yearAsNumber, monthAsNumber, dayAsNumber);
elementToReturn.data.setUTCFullYear(yearAsNumber, monthAsNumber, dayAsNumber);
codestringToReturn = codestring.slice(offSet + 6, codestringLength);
elementToReturn.raw = codestring.slice(offSet, offSet+6);
}
Expand Down