-
-
Notifications
You must be signed in to change notification settings - Fork 47
Fix async generator issue and prefer opcode comparison to name comparison everywhere #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 7 7
Lines 2025 2028 +3
Branches 452 449 -3
=======================================
+ Hits 1927 1930 +3
Misses 54 54
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Running the benchmark found in #172 does not show a significant improvement (on one run it looks faster on average but the variance is large). |
|
@MatthieuDartiailh thanks for putting this together and apologies for the late reply but I've not had much time to look into this. It sounds like there are no measurable performance improvements from this, but I think there still is the advantage of cleaner coding anyway. May I suggest splitting this PR into 3 separate ones to address the 3 individual goals and keep the git history cleaner? |
|
Sure I can split the work between dropping 3.9 and 3.10 (and subsequent simplifications) and the rest. But what is the third part you would have seen ? @P403n1x87 |
Based on the PR title I thought this PR had 3 parts:
|
|
Yes but dumping 3.9 and 3.10 without taking advantage of that to remove the related version checks feels like unfinished work to me. I will split in 2. |
1ada6e0 to
4cb9dfd
Compare
4cb9dfd to
a098384
Compare
a098384 to
2d9a0fd
Compare
Closes #178