Fixes #118 bookmarks hiding when switching buffer#169
Open
MattesGroeger wants to merge 1 commit intomasterfrom
Open
Fixes #118 bookmarks hiding when switching buffer#169MattesGroeger wants to merge 1 commit intomasterfrom
MattesGroeger wants to merge 1 commit intomasterfrom
Conversation
|
This fixes the issue I had trying to use this plugin alongside whichkey. The bookmarks used to disappear, but this seems to fix the bug. |
|
A problem that was introduced in this branch was that bookmark signs were invisible when starting nvim and entering files that have bookmarks added to them. I created a fork based on the master branch where both functionalities are no more of an issue #174 |
JS-Zheng
added a commit
to JS-Zheng/vim-bookmarks
that referenced
this pull request
Sep 13, 2022
stm-enspired
approved these changes
Nov 17, 2023
stm-enspired
left a comment
stm-enspired
left a comment
There was a problem hiding this comment.
patch looks good and fixes the disappearing bookmark signs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just quickly created this PR so the fix can be verified. I didn't test myself yet (besides this one use case). Please go ahead and help me testing.