Skip to content

Conversation

@jamesmacwilliam
Copy link

Hi Leandro,

I stumbled upon your gem when trying out Zyte. Love the simplicity of your approach, but we ended up running into some dependency errors, and I lean more toward keeping the http request in the current thread rather than splitting it out in a new thread using curl. Let me know what you think of my proposed changed, these are what we needed to get it working with our app, I'd love to collaborate with you further if you have additional ideas to enhance the library.

==========================================

  • reduce the dependency list and version constraints to minimize gem conflicts when installing on mature apps
  • default to httpResponseBody (ensures we get some valid response if just trying with a url)
  • use native ruby libraries rather than curl
  • remove the data file that was generated with curl (given that most apps are containerized, this seems like a liability, at a minimum it should be optional to prevent generation in production

- reduce the dependency list and version constraints to minimize
  gem conflicts when installing on mature apps
- default to httpResponseBody (ensures we get some valid response if
  just trying with a url)
- use native ruby libraries rather than curl
- remove the data file that was generated with curl (given that most
  apps are containerized, this seems like a liability, at a minimum it
  should be optional to prevent generation in production
@leandrosardi
Copy link
Member

Hello @jamesmacwilliam - Thank you for collaborating with this project.

I will be checking your proposed changes this week.

I will reply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants