Conversation
11f00a0 to
e32257b
Compare
* use template structures for improved code reuse * replace NonIntegerTimestampDataParametricMonitorFixture with the generic DataParametricMonitorFixture
e32257b to
63c7779
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements epsilon (unobservable) transition support in the BooleanMonitor class, following the same approach used in PR #15 for the DataParametricMonitor. The implementation adds the ability to handle transitions labeled with action ID 127 (unobservable actions) that can occur without consuming input events.
Changes:
- Implemented epsilon transition handling in BooleanMonitor with time advancement based on clock guards
- Refactored test fixtures to support both boolean and data parametric monitors with improved naming conventions
- Added comprehensive test coverage for epsilon transitions in various scenarios including guards, multiple clock variables, and accept state transitions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/fixture/epsilon_transition_automaton_fixture.hh |
Added #pragma once, makeBooleanTA() method, made methods const, renamed constants to SCREAMING_SNAKE_CASE, and converted fixtures to inline const |
test/data_parametric_monitor_test.cc |
Updated to use refactored fixture names (FIXTURE1-4) and consolidated fixture structure |
test/boolean_monitor_test.cc |
Refactored with template-based fixtures and added four new epsilon transition test cases covering various scenarios |
src/boolean_monitor.hh |
Added epsilon transition support: Configuration now tracks absolute time, implemented epsilonTransition() method, destructor calls epsilon transitions for final processing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MasWag
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement unobservable transition in BooleanMonitor using the same approach as #15
Close #7.