Fully backward compatible revision to allow for parseing from str data as well as files and gzipped files. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzipped files. It is fully backwards compatible. README.rst Added an example isc_dhcp_leases/iscdhcplease.py Unindented processing in IscDhcpLease.get after lease_data was attained to both release the file sooner and facilitate parseing from a string. Added some comments to IscDhcpLeases to help with the parameters. Added a optional bool:is_data to IscDhcpLeases to indicate the given source was str data and not a file name. ps: I really wanted to change the name of IscDhcpLease.filename to .sources to make it cleared but there's that miniscule chance that someone somewhere actually used a named parameter or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see others have asked for the ability to parse from data as well. I offer revision this for your consideration.
I did not do anything about unit tests though.
ps: I really wanted to change the name of IscDhcpLease.filename to .source to make it cleared but there's that miniscule chance that someone somewhere actually used a named parameter or something.