Dockerfile and installation updates #688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a few different updates to the Dockerfile configuration and installation scripts.
Tester-specific updates
stackis correctly installed system-wide; I removed the unnecessaryPATHupdates in the Haskell tester files.ghcbeing installed by ghcup (now the only ghc versions that should be installed are the system version withapt-get install ghcand any additional ghc versions installed bystack)stack updatebeforestack buildin the Haskell testersetup.py::installfunction. This improves the runtime of the first subsequentstack buildcall, which happens when a new Haskell test environment is created.requirements.systemfile rather than the Dockerfile.General updates
set -euxo pipelineto each script to ensure failed installation steps are correctly reported and all steps are echoedCMD.--mountarguments toRUNcommands; reordering steps; and adding an explicitCOPYfor therequirements.systemfiles to prevent cache invalidation for the installation step caused by modifying other files in the repository.