Accommodate more variables being set by callers (for MT, RC, C- and C++- compilers)#152
Merged
MarkSchofield merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#148 highlights opportunities for using WindowsToolchains for finding, say, Windows SDKs, but using other tooling - like LLVM's 'mt' or 'rc' - for compilation steps. That's a bit tricky at the minute, because
Windows.Kits.cmake/Windows.Clang.toolchain.cmake/Windows.MSVC.toolchain.cmakemake too many assumptions. This change;Windows.Kits.cmaketo only setCMAKE_MTorCMAKE_RC_COMPILER[_INIT]if values aren't already set. This allows callers to prefer llvm-mt or llvm-rc.Windows.Clang.toolchain.cmaketo not setCMAKE_C_COMPILERorCMAKE_CXX_COMPILERif they have already been set.CMAKE_TRY_COMPILE_PLATFORM_VARIABLESto ensure that the caller-provided values are propagated into 'try compile'.