Align the CMAKE_TRY_COMPILE_PLATFORM_VARIABLES between *.toolchain.cmake files#151
Merged
MarkSchofield merged 1 commit intomainfrom Feb 2, 2026
Merged
Align the CMAKE_TRY_COMPILE_PLATFORM_VARIABLES between *.toolchain.cmake files#151MarkSchofield merged 1 commit intomainfrom
MarkSchofield merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150.
#150 called out that the
CMAKE_TRY_COMPILE_PLATFORM_VARIABLESvalue is different betweenWindows.Clang.toolchain.cmakeandWindows.MSVC.toolchain.cmake. In this particular caseCMAKE_VS_VERSION_PRERELEASEbeing missing meant that the 'try compile' wasn't finding the same Visual Studio instance as the Toolchain originally was, but propagating - say -VS_INSTALLATION_PATHandVS_INSTALLATION_VERSIONwill minimize the amount of work that the Toolchain performs within the 'try compile'.Realistically, the toolchain files should share scripts for commonality, but that seems out-of-scope for now; that seems like it should be done as part of the file-structure reshuffling. Getting this fix in first seems more important.
I'm also adding
CMAKE_WINDOWS_KITS_10_DIRto theCMAKE_TRY_COMPILE_PLATFORM_VARIABLES, so that a manually setCMAKE_WINDOWS_KITS_10_DIRpropagates into the 'try compile'.