Use 'CMAKE_<LANG>_STANDARD_LINK_DIRECTORIES' if available#127
Open
MarkSchofield wants to merge 1 commit intomainfrom
Open
Use 'CMAKE_<LANG>_STANDARD_LINK_DIRECTORIES' if available#127MarkSchofield wants to merge 1 commit intomainfrom
MarkSchofield wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
Hmm... My CUDA builds failed because they fail to find kernel32. I tried setting 'CMAKE_CUDA_STANDARD_LINK_DIRECTORIES', too, but that didn't help :/ |
MarkSchofield
force-pushed
the
mschofie/standard-link-directories
branch
from
db39aaf to
4c36cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
As called out in #112, CMake toolchains shouldn't use
link_directoriesandinclude_directories- discussed in the thread 'cross compile - adding standard link directories in a toolchain file' on the CMake forums.Issue #67 called out that
include_directoriesare bad, and those occurrences were fixed with #69. Removinglink_directoriesneeds support forCMAKE_<LANG>_STANDARD_LINK_DIRECTORIES, and that first shipped in CMake 3.31. This change checks to see if CMake is 3.31 or higher, and if so prefersCMAKE_<LANG>_STANDARD_LINK_DIRECTORIESoverlink_directories.