Preset includes should be loaded relative to the include'ing file#87
Merged
MarkSchofield merged 1 commit intodevelopfrom Dec 24, 2025
Merged
Conversation
MarkSchofield
temporarily deployed
to
General
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86.
When loading 'include' presets, relative paths should be loaded relative to the include'ing file. This manifests when building with a CMakePresets.json with includes, but building from a sub-folder - the include is - incorrectly - resolved relative to the sub-folder.
The fix reshuffles a little. There already was validation that the included file was present, but that happened when processing the include, not when loading the include from the file. In order to have the root folder to load from, work to resolve and validate the include is performed when loading from the file.