Consolidate configure- and build- preset code#81
Merged
MarkSchofield merged 3 commits intodevelopfrom Nov 9, 2025
Merged
Conversation
…lidate preset resolution
…te preset resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many paths in PSCMake need to find a build- or configuration- preset. The code accepts a preset name through CmdLet parameters, asks for the names of possible presets, matches against the preset name that was passed, and - having resolved a preset - resolves the preset object it needs. This 'two pass' lookup is more work - to be able to support 'user presets' or 'included presets', it would make more sense to consolidate the lookup so the full suite of presets is resolved in one place. And that's what this PR does - getting the full presets up-front. There are individual commits switching 'configure presets' and then 'build presets', and then consolidation of common code.