feat: add SQLAlchemy storage adapter#8
Merged
Maneesh-Relanto merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
Closes the critical 'BLOCKING PRODUCTION USE' gap by providing a
persistent SQL-backed storage backend.
## What's new
### src/rbac/storage/sqlalchemy_adapter.py (new)
- SQLAlchemyStorage class extending BaseStorage
- Full CRUD for Users, Roles, Permissions, Resources, RoleAssignments
- SQLAlchemy 2.x declarative ORM with 6 tables:
rbac_users, rbac_roles, rbac_permissions, rbac_resources,
rbac_role_permissions (M:M junction), rbac_role_assignments
- Proper indexes on domain, email, resource_type columns
- JSON columns for attributes/conditions/metadata (portable across DBs)
- Soft-delete for Users, Roles, Resources (status='deleted')
- Cascade deletes: deleting a user/role removes its assignments
- Circular hierarchy detection for role parent updates
- Thread-safe scoped sessions with auto commit/rollback
- initialize() / dispose() lifecycle methods
- Compatible connection kwargs for SQLite and pooled DBs
- Supports: SQLite (:memory: and file), PostgreSQL, MySQL
### src/rbac/storage/__init__.py
- Export SQLAlchemyStorage with graceful ImportError guard (SQLAlchemy optional)
### requirements.txt
- Uncommented sqlalchemy>=2.0.0 as an active dependency
- Left psycopg2-binary and pymysql commented (install per DB driver)
### tests/test_sqlalchemy_storage.py (new)
- 50 tests across 7 test classes using sqlite:///:memory:
- TestLifecycle, TestUserCRUD, TestRoleCRUD, TestPermissionCRUD,
TestResourceCRUD, TestRoleAssignments, TestUtility, TestPersistence
- Persistence test uses tmp_path file DB to verify write → new instance → read
- All 50 tests pass in < 1 second
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the critical 'BLOCKING PRODUCTION USE' gap by providing a persistent SQL-backed storage backend.
What's new
src/rbac/storage/sqlalchemy_adapter.py (new)
src/rbac/storage/init.py
requirements.txt
tests/test_sqlalchemy_storage.py (new)