Skip to content

Conversation

@nebspacefarer
Copy link

Hello! First contribution here.

Commit 839b4c4 aim to fix #149 by creating folder only when _create_folder_check is checked on the dialog UI, else it directly emits the signal.

Commit 1fcef2c aim to fix an issue that wrongly reset the content of the _project_path_line_edit.text to the default config projects folder when editing the _project_name_edit.text .
In the commit, if _create_folder_check is checked, it should add a sanitized _project_name_edit.text to the current path after the last parent folder (fetched with the substr() and rfind() present in the commit).
If the _create_folder_check is not checked, we keep the implementation as it is, pulling the config default projects folder and adding the project name.

As writing this, forgot to sanitize the project name, fixing this and this should be ready to merge.

@nebspacefarer
Copy link
Author

Added the necessary sanitizing with the existing _format_dir_name() method.
Changing status from draft to ready.

@nebspacefarer nebspacefarer marked this pull request as ready for review November 8, 2025 22:39
@nebspacefarer
Copy link
Author

This last commit was necessary to correctly parse _project_name_edit.text. The added separator allows to retrieve the desired directory by doing a rfind() (reverse find, last occurence) on it.
The separator / should be supported on Windows as well since Vista, but this was only tested on Linux so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

couldnt create folder code 32. linux cachyos

1 participant