Skip to content

Gift card no lazyload and preload gift #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbojcic1 wants to merge 2 commits into from
Closed

Gift card no lazyload and preload gift #865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9280945
Don't lazy load gift card images
jbojcic1 Feb 17, 2026
d571529
Preload gift card images on gift cards route
jbojcic1 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/components/wallet-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export function WalletCardBackgroundImage({
<img
src={src}
alt={alt}
loading="lazy"
className={cn('h-full w-full object-cover', className)}
/>
</WalletCardOverlay>
Expand Down
2 changes: 2 additions & 0 deletions app/features/gift-cards/use-discover-cards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export const GIFT_CARDS: GiftCardInfo[] = [
},
];

export const GIFT_CARD_IMAGES = GIFT_CARDS.map((card) => card.image);

/**
* Returns the gift card image for a given URL, if one exists.
*/
Expand Down
10 changes: 9 additions & 1 deletion app/routes/_protected.gift-cards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
import { Outlet } from 'react-router';
import { type LinksFunction, Outlet } from 'react-router';
import '~/features/gift-cards/transitions.css';
import { GIFT_CARD_IMAGES } from '~/features/gift-cards/use-discover-cards';

export const links: LinksFunction = () =>
GIFT_CARD_IMAGES.map((imageUrl) => ({
rel: 'preload',
href: imageUrl,
as: 'image',
}));

export default function GiftCardsLayout() {
return <Outlet />;
Expand Down