Add account purpose for #758 by gudnuf · Pull Request #766 · MakePrisms/agicash

gudnuf · 2026-01-12T21:50:09Z

This PR is to solve this comment: #758 (comment)

Add a new purpose column to the account's table.
Handles accounts based on their purpose
Creates accounts with their purpose. Spark accounts are always transactional for now, and cashu account are transactional | gift-card.
The cashu account purpose is set based on whether the mint is closed loop or not.

vercel · 2026-01-12T21:50:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
agicash	Ready	Preview, Comment	Jan 27, 2026 4:22pm

supabase · 2026-01-12T21:50:24Z

Updates to Preview Branch (add-account-purpose) ↗︎

Deployments	Status	Updated
Database	✅	Tue, 27 Jan 2026 16:22:21 UTC
Services	✅	Tue, 27 Jan 2026 16:22:21 UTC
APIs	✅	Tue, 27 Jan 2026 16:22:21 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	✅	Tue, 27 Jan 2026 16:22:22 UTC
Migrations	✅	Tue, 27 Jan 2026 16:22:22 UTC
Seeding	✅	Tue, 27 Jan 2026 16:22:22 UTC
Edge Functions	✅	Tue, 27 Jan 2026 16:22:22 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

gudnuf · 2026-01-12T22:28:27Z

@jbojcic1 the first commit here adds the account purpose feature and the second two commits are other feedback that Bob wanted me to do. They utilize the account purpose so I put them here so you could see the usage too

gudnuf · 2026-01-13T03:31:02Z

app/lib/cashu/utils.ts

+  mintInfo: ExtendedMintInfo | null | undefined,
+): 'gift-card' | 'transactional' => {
+  // TODO: This should check this.mintInfo?.agicash?.closed_loop once Agicash mints change to that
+  // TODO: Should the mint explicitly signal the purpose?


We will have other types of mints like loyalty points, subscription credits, reward points / cash back, etc.

I keep wondering what the best way to handle this on the mint side is and now I'm wondering if it would be better to specify the purpose in the agicash mint info rather than the closed_loop flag that I added to PROTOCOL_EXTENSIONS

will those all also be closed_loop or you see more settings added to the mint? if all closed loop, probably better to keep as is

I think there's many possibilities. Most will be closed loop, but the meaning of closed loop may change. For example, we may have mints that are only allowed to pay invoices that they themselves generated or we might have mints that have multiple valid destinations in the loop. And then the behavior of the mint could be different based on the type. Gift card mints just issue ecash that can only be spent at a specific location, but cash back mints will work differently (not sure how yet).

We can always change later if needed

yeah lets keep as is and change later. it's hard to predict something like that. i do feel like purpose should not be moved to mint side for now. seems like a concept that is higher level than the mint atm

app/features/gift-cards/add-gift-card.tsx

jbojcic1 · 2026-01-26T11:13:27Z

app/features/gift-cards/gift-card-details.tsx

I don't think we need to specify cashu here now that we have purpose set, right?

mm thats for the generic typing. If we remove that the the accounts will just be Account not CashuAccount. We could change the useAccounts hook to type gift card accounts as CashuAccount, wdyt?

I pushed a change in this commit f725a99 that updates the useAccounts hook to make it so that if you specify gift-card the accounts returned will be cashu. Also the way I did it as a union makes it so that if you try to set type to 'spark' and purpose to 'gift-card' ts will give an error.

I pushed so you could see and maybe you have a suggestion, but I'm not sure if this is better than just specifying the type along with the purpose.

Pros/cons:

New overload approach

Overload is nice because it encodes "gift cards are always cashu" in the type system and makes it impossible to accidentally write { type: 'spark', purpose: 'gift-card' }, but it makes the makes the hook signature more complex.

Manual specify type

The original way I had it is more obvious what type you're getting and keeps the hook simpler, but potentially redundant and doesn't prevent you from writing { type: 'spark', purpose: 'gift-card' }

Other pro of manual type is that if we can later have gift cards for different types we don't need to change anything but we are probably far from there so I'd just keep what you did here.

Alterantively we could keep both type and purpose but have dedicated hook called useGiftCardAccounts which wraps it so we don't need to repeat it all the time

I'm keeping it

app/features/gift-cards/gift-cards.tsx

supabase/migrations/20260112180000_add_account_purpose.sql

jbojcic1 · 2026-01-26T11:24:01Z

app/lib/cashu/utils.ts

+  mintInfo: ExtendedMintInfo | null | undefined,
+): 'gift-card' | 'transactional' => {
+  // TODO: This should check this.mintInfo?.agicash?.closed_loop once Agicash mints change to that
+  // TODO: Should the mint explicitly signal the purpose?


will those all also be closed_loop or you see more settings added to the mint? if all closed loop, probably better to keep as is

app/features/receive/receive-cashu-token-hooks.tsx

app/features/receive/receive-cashu-token-service.ts

app/features/accounts/account-hooks.ts

app/features/settings/accounts/add-mint-form.tsx

jbojcic1 · 2026-01-27T10:49:32Z

app/features/accounts/account-hooks.ts

+): UseSuspenseQueryResult<ExtendedAccount<T>[]>;
+export function useAccounts<T extends AccountType = AccountType>(
+  select?: UseAccountsSelect<T>,
+): UseSuspenseQueryResult<ExtendedAccount<T>[]> {


if we decide to keep this approach I think it would be less confusing to do it like this:

export function useAccounts( select: UseAccountsSelect<'cashu', 'gift-card'>, ): UseSuspenseQueryResult<ExtendedAccount<'cashu'>[]>; export function useAccounts< T extends AccountType = AccountType, P extends AccountPurpose = AccountPurpose, >( select?: UseAccountsSelect<T, P>, ): UseSuspenseQueryResult<ExtendedAccount<T>[]>; export function useAccounts< T extends AccountType = AccountType, P extends AccountPurpose = AccountPurpose, >( select?: UseAccountsSelect<T, P>, ): UseSuspenseQueryResult<ExtendedAccount<T>[]> { ...

this way you actually utilise the second generic param instead of having it but using & { purpose: 'gift-card' }

Oh yea nice, that was left over from a previous attempt before doing these overloads. Fixed

jbojcic1

Approved, pls just check #766 (comment)

gudnuf requested a review from jbojcic1 January 12, 2026 21:50

gudnuf self-assigned this Jan 12, 2026

vercel bot deployed to Preview January 12, 2026 22:28 View deployment

gudnuf mentioned this pull request Jan 13, 2026

add gift cards #758

Merged

gudnuf commented Jan 13, 2026

View reviewed changes

jbojcic1 reviewed Jan 26, 2026

View reviewed changes

vercel bot deployed to Preview January 27, 2026 00:31 View deployment

vercel bot deployed to Preview January 27, 2026 01:01 View deployment

vercel bot deployed to Preview January 27, 2026 01:52 View deployment

gudnuf force-pushed the add-account-purpose branch from be1d220 to 94f4b47 Compare January 27, 2026 01:52

vercel bot deployed to Preview January 27, 2026 01:53 View deployment

gudnuf requested a review from jbojcic1 January 27, 2026 01:58

gudnuf mentioned this pull request Jan 27, 2026

add internal_melts_only to MintInfo and cache mint info #658

Closed

gudnuf force-pushed the add-account-purpose branch from 94f4b47 to f9d089c Compare January 27, 2026 03:07

vercel bot deployed to Preview January 27, 2026 03:08 View deployment

jbojcic1 reviewed Jan 27, 2026

View reviewed changes

jbojcic1 approved these changes Jan 27, 2026

View reviewed changes

add account purpose and some more changes

888e577

gudnuf force-pushed the add-account-purpose branch from f9d089c to 888e577 Compare January 27, 2026 16:21

vercel bot deployed to Preview January 27, 2026 16:22 View deployment

gudnuf merged commit ae37b7b into gift-cards-2 Jan 27, 2026
5 checks passed

gudnuf deleted the add-account-purpose branch January 27, 2026 16:42

Conversation

gudnuf commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gudnuf commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbojcic1 Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gudnuf Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Pros/cons:

New overload approach

Manual specify type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbojcic1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

gudnuf commented Jan 12, 2026 •

edited

Loading

vercel bot commented Jan 12, 2026 •

edited

Loading

supabase bot commented Jan 12, 2026 •

edited

Loading

gudnuf commented Jan 12, 2026 •

edited

Loading

jbojcic1 Jan 27, 2026 •

edited

Loading

gudnuf Jan 27, 2026 •

edited

Loading