deterministic P2PK secrets#630
Open
gudnuf wants to merge 2 commits intointroduce-spending-conditionsfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension to #627
Before now there has not been any definition of deterministic P2PK secrets and the cashu-ts
OutputData.createP2pkDatamethod does not allow us to create P2PK output data deterministically.The way that I implemented this is by deriving a deterministic nonce for each P2PK secret. This nonce is derived using the same derivation path as the
secret's defined by NUT-13.We should confirm that we don't want a new derivation path for the nonce.
Warning
This will not allow for p2pk proofs to be recovered from just a seed because without our wallet state we have no way of knowing the public key that the proofs were locked to. This is only useful for creating idempotent send-swaps. This means if a user ever tried to recover from seed, then all of the counters used to create P2PK secrets will not return any signatures