-
Notifications
You must be signed in to change notification settings - Fork 17
DOC-561-SQL-Support-Changes #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ghost
commented
Dec 21, 2022
- Doc 561 SQL support changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dlozina-macrometa, are you planning to finish this? |
|
@dlozina-macrometa, what is the status of this PR? |
jamesm-macrometa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@dlozina-macrometa, just a reminder that this still needs attention and merging |
| title: Advanced SQL Queries | ||
| --- | ||
|
|
||
| ## Case Sensitivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- Always leave an empty line under headings.
- Do not stack headings. In this case, the H1 generated by the title will be stacked atop this H2. Add a short intro explaining what this topic is about above Case Sensitivity.
diana-macrometa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor edits, then this is good to go!
| - PERCENTILE_CONT | ||
|
|
||
| :::note | ||
| Users can use mathematical functions such as degrees and logarithm with arbitrary base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Users can use mathematical functions such as degrees and logarithm with arbitrary base. | |
| Users can use mathematical functions such as degrees and logarithms with an arbitrary base. |
| ``` | ||
|
|
||
| :::note | ||
| Users can't use `HAVING` clause with subqueries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Users can't use `HAVING` clause with subqueries. | |
| You can't use `HAVING` clause with subqueries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always write to "you," not "user."
|
@dlozina-macrometa, how's this going? |