Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 21, 2022

  • Doc 561 SQL support changes

@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 4:03PM (UTC)

@diana-macrometa diana-macrometa changed the base branch from master to release-cedar December 21, 2022 17:25
@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, are you planning to finish this?

@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, what is the status of this PR?

Copy link
Contributor

@jamesm-macrometa jamesm-macrometa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, just a reminder that this still needs attention and merging

title: Advanced SQL Queries
---

## Case Sensitivity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • Always leave an empty line under headings.
  • Do not stack headings. In this case, the H1 generated by the title will be stacked atop this H2. Add a short intro explaining what this topic is about above Case Sensitivity.

Copy link
Contributor

@diana-macrometa diana-macrometa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor edits, then this is good to go!

- PERCENTILE_CONT

:::note
Users can use mathematical functions such as degrees and logarithm with arbitrary base.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users can use mathematical functions such as degrees and logarithm with arbitrary base.
Users can use mathematical functions such as degrees and logarithms with an arbitrary base.

```

:::note
Users can't use `HAVING` clause with subqueries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users can't use `HAVING` clause with subqueries.
You can't use `HAVING` clause with subqueries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always write to "you," not "user."

@ghost ghost changed the base branch from release-cedar to 17-12-release February 23, 2023 17:54
@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, how's this going?

Base automatically changed from 17-12-release to main April 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants