Phase G: Testing Strategy & Contract Enforcement #2
Conversation
- Implements Contract tests for AdapterInterface. - Implements Unit tests for MySQL, Redis, and Mongo adapters. - Implements Unit tests for MySQL, Redis, and Mongo factories, covering success and failure paths. - Ensures strict DI and ownership enforcement (no logic in adapters). - Mocks all drivers to ensure 100% determinism (no network/IO). - Handles missing Redis extension gracefully via test-scoped polyfill. - Achieves 100% code coverage.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Removed `class Redis {}` polyfills; installed `php-redis` and `php-mongodb` in CI environment.
- Refactored exception assertions to use `expectExceptionObject` for strict verification of previous exceptions without try/catch blocks.
- Achieved 100% coverage and passing PHPStan.
- Replaces `expectExceptionObject` with mandatory `expectException` + `try/catch` + `re-throw` pattern in factory failure tests. - Ensures all factory failure tests explicitly assert the previous exception instance. - Maintains 100% coverage and passing PHPStan.
This PR introduces a comprehensive test suite for
maatify/data-adapters, fulfilling Phase G requirements.It adds tests for all adapters and factories, ensuring strict contract enforcement and zero side effects.
Tests are deterministic and run without external infrastructure.
The suite includes:
Redisclass to allow testing without the extension.PR created automatically by Jules for task 16637388639650812853 started by @Maatify