Skip to content

use ccache in GitHub actions #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschimme merged 1 commit into from
Dec 22, 2025
Merged

use ccache in GitHub actions #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/build-appimage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: ccache
uses: hendrikmuhs/ccache-action@v1.2
with:
create-symlink: true
key: ${{ github.job }}

- name: Install Build Dependencies
run: |
sudo apt update -qq
Expand Down Expand Up @@ -47,7 +53,9 @@ jobs:
-DWITH_WEBSOCKET=ON \
-DWITH_QTKEYCHAIN=ON \
-DWITH_TESTS=OFF \
-DPACKAGE_TYPE=AppImage
-DPACKAGE_TYPE=AppImage \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
make -j$(getconf _NPROCESSORS_ONLN)
make DESTDIR=appdir install

Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ jobs:
with:
fetch-depth: 0
submodules: true
- if: runner.os == 'Linux' || runner.os == 'macOS'
name: ccache
uses: hendrikmuhs/ccache-action@v1.2
with:
create-symlink: true
key: ${{ github.job }}-${{ matrix.os }}
- if: runner.os == 'Windows' || runner.os == 'macOS'
uses: lukka/get-cmake@latest
- if: runner.os == 'Windows'
Expand Down Expand Up @@ -84,7 +90,7 @@ jobs:
mkdir -p build ${{ github.workspace }}/artifact
cd build
cmake --version
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -G 'Ninja' -DCPACK_PACKAGE_DIRECTORY=${{ github.workspace }}/artifact $MMAPPER_CMAKE_EXTRA -DWITH_WEBSOCKET=ON -DWITH_QTKEYCHAIN=ON -S .. || exit -1
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -G 'Ninja' -DCPACK_PACKAGE_DIRECTORY=${{ github.workspace }}/artifact $MMAPPER_CMAKE_EXTRA -DWITH_WEBSOCKET=ON -DWITH_QTKEYCHAIN=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -S .. || exit -1
Copy link

@sourcery-ai sourcery-ai bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Guard the CMake ccache launcher flags to match the platforms where ccache is configured

These -DCMAKE_*_COMPILER_LAUNCHER=ccache flags are always set, but the ccache setup only runs on Linux/macOS. On Windows this will likely reference a non‑existent ccache binary and break configuration. Please gate these flags with the same if: runner.os == 'Linux' || runner.os == 'macOS' condition (e.g., via an env var or matrix flag) so they’re only applied where ccache is available.

cmake --build . --parallel

# Package
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ jobs:
with:
fetch-depth: 0
submodules: true
- if: runner.os == 'Linux' || runner.os == 'macOS'
name: ccache
uses: hendrikmuhs/ccache-action@v1.2
with:
create-symlink: true
key: ${{ github.job }}-${{ matrix.os }}-${{ matrix.compiler }}
- if: runner.os == 'Windows' || runner.os == 'macOS'
uses: lukka/get-cmake@latest
- if: matrix.compiler == 'msvc'
Expand Down Expand Up @@ -130,7 +136,7 @@ jobs:
mkdir -p build ${{ github.workspace }}/artifact
cd build
cmake --version
cmake -DCMAKE_BUILD_TYPE=Debug -G 'Ninja' -DWITH_MAP=OFF -DCPACK_PACKAGE_DIRECTORY=${{ github.workspace }}/artifact $MMAPPER_CMAKE_EXTRA -DWITH_WEBSOCKET=ON -DWITH_QTKEYCHAIN=ON -S .. || exit -1
cmake -DCMAKE_BUILD_TYPE=Debug -G 'Ninja' -DWITH_MAP=OFF -DCPACK_PACKAGE_DIRECTORY=${{ github.workspace }}/artifact $MMAPPER_CMAKE_EXTRA -DWITH_WEBSOCKET=ON -DWITH_QTKEYCHAIN=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -S .. || exit -1
cmake --build . --parallel

#
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/build-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: ccache
uses: hendrikmuhs/ccache-action@v1.2
with:
create-symlink: true
key: ${{ github.job }}

- name: Install Qt for Wasm
uses: jurplel/install-qt-action@v4
with:
Expand All @@ -42,7 +48,9 @@ jobs:
-DWITH_WEBSOCKET=ON \
-DWITH_UPDATER=OFF \
-DCMAKE_BUILD_TYPE=Release \
-DPACKAGE_TYPE=Wasm
-DPACKAGE_TYPE=Wasm \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
cmake --build build

- name: Add coi-serviceworker.js
Expand Down