Skip to content

fix: add create to skill and remove contains check from hookTree #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordMidas wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: add create to skill and remove contains check from hookTree #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions msu/hooks/skills/skill.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
::MSU.MH.hookTree("scripts/skills/skill", function(q) {
if (!q.contains("create"))
return;

q.create = @(__original) function()
{
if (this.m.DamageType == null)
Expand All @@ -27,6 +24,12 @@
q.m.IsApplyingPreview <- false;
q.m.PreviewField <- {};

// Add create function in skill.nut which doesn't exist in vanilla
// so hookTree on skill doesn't need a `.contains("create")` check
q.create <- function()
{
}

q.isType = @() function( _t, _any = true, _only = false )
{
if (_any)
Expand Down