Add configurable custom MCM regex limits #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented configurable limits (both lines and characters) for searching regex match in a custom/MCM file, using customTxtDefinition.txt. This is needed for finding translatable strings in files where a match can't be found within the previous limits, causing the files not being recognized. This can occur in files where only a few strings are translatable. Changes: - Added `CustomTypeLineLimit` and `CustomTypeSizeLimit` to customTxtDefinition.txt. - Added `iLineLimit` & `iSizeLimit` properties to `rcustomTxtDefinition` and `getLineLimit` & `getSizeLimit` methods to `pcustomTxtDefinition`. - Edited `tCustomTxt.mcmDecider()` function to use the configurable limits instead of the fixed ones. Previous values are set as default.
vanmatten
force-pushed
the
configurable-limits
branch
from
aae21bb to
1839816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented configurable limits (both lines and characters) for searching regex match in a custom/MCM file, using customTxtDefinition.txt. This is needed for finding translatable strings in files where a match can't be found within the previous limits, causing the files not being recognized. This can occur in files where only a few strings are translatable.
Changes:
CustomTypeLineLimitandCustomTypeSizeLimitto customTxtDefinition.txt.iLineLimit&iSizeLimitproperties torcustomTxtDefinitionandgetLineLimit&getSizeLimitmethods topcustomTxtDefinition.tCustomTxt.mcmDecider()function to use the configurable limits instead of the fixed ones. Previous values are set as default.This changes aren't tested because I don't know how to do it.