Skip to content

Feature: Change python __version__ to semver #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WhoBrokeTheBuild wants to merge 1 commit into
base: alpha
Choose a base branch
from
+7 −5
Open

Feature: Change python __version__ to semver #3027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions python/MDSplus/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,14 @@ class libs:
# check version
if __name__ == "MDSplus":
version_check = os.getenv("MDSPLUS_VERSION_CHECK", "on").lower()
version_check = not (
version_check == "0" or version_check == "off" or version_check == "no")
version_check = not (version_check == "0" or version_check == "off" or version_check == "no")
else:
version_check = False

try:
_version = _mimport('_version')
__version__ = _version.release_tag
__version__ = '.'.join(map(str, _version.version))
release_tag = _version.release_tag
__doc__ = """%s
Version: %s
Release Date: %s
Expand All @@ -94,6 +95,7 @@ class libs:
sys.stderr.write(
"PYTHONPATH was set to: %s and unable to import version information\n" % os.environ['PYTHONPATH'])
__version__ = "unknown"
release_tag = "unknown"

if version_check:
def version_check():
Expand All @@ -102,13 +104,13 @@ def version_check():
verchk = _ver.tostr(libs.MdsShr.MdsRelease())
except Exception:
verchk = "unknown"
if verchk != __version__ or verchk == "unknown":
if verchk != release_tag or verchk == "unknown":
sys.stderr.write('''Warning:
The MDSplus python module version (%s) does not match
the version of the installed MDSplus libraries (%s).
Upgrade the module using the mdsplus/python/MDSplus directory of the
MDSplus installation or set PYTHONPATH=/usr/local/mdsplus/python.
''' % (__version__, verchk))
''' % (release_tag, verchk))
version_check()
del version_check

Expand Down