Fix: READ() removing last character of file#2999
Open
WhoBrokeTheBuild wants to merge 1 commit intoMDSplus:alphafrom
Open
Fix: READ() removing last character of file#2999WhoBrokeTheBuild wants to merge 1 commit intoMDSplus:alphafrom
WhoBrokeTheBuild wants to merge 1 commit intoMDSplus:alphafrom
Conversation
joshStillerman
approved these changes
Dec 10, 2025
e35bf6c to
cef1bc5
Compare
When a file does not end with a newline, READ() erroneously strips off the last character of the last line. This simply checks that it is a newline before removing it.
cef1bc5 to
ae894ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file does not end with a newline,
READ()erroneously strips off the last character of the last line.This simply checks that it is a newline before removing it.
example.txtPreviously, the last read() would have returned
"This line doesn'"