Bug Fix Null Pointer Exception when gun crafting with edited default gun pack#263
Open
hikokio wants to merge 1 commit intoMCModderAnchor:1.20.1from
Open
Bug Fix Null Pointer Exception when gun crafting with edited default gun pack#263hikokio wants to merge 1 commit intoMCModderAnchor:1.20.1from
hikokio wants to merge 1 commit intoMCModderAnchor:1.20.1from
Conversation
qualk
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
After removing some items from the default gun pack (I'm creating a modpack with only the pistols, and many attachments are removed), opening the gun crafting table causes a null pointer exception as the
recipeIdGroupsis null instead of an empty object. This crashes the client.After adding the check for
nullthe user is able to use the gun crafting table without crashing.