Skip to content

Conversation

@william-deeken
Copy link

This pull has the following updates:

  1. Updating DayOfMonthTrigger to have a new data member "Date Type" with select choices "Variable Date" or "Specific Date".
  2. The "Specific Date" selection would cause this trigger configuration to behave as is currently does. User has the ability to choose Trigger Days and Trigger Times.
  3. The "Variable Date" choice will hide Trigger Days configuration and instead show "Nth Weekday", a value between 1-5 inclusive, and Weekday (Mon-Sun).
  4. New methods DayOfMonthTrigger.GetVariableDateOfMonth, DayOfMonthTrigger.GetNextMonthWithValidVariableDate to handle getting the current month's next run time and the next valid runtime after the current month.
  5. Update existing methods for new trigger type.
  6. Resource files - Added new help text, dashboard schedule string format, for new settings/trigger type (English only).
  7. Updated test project to test new functionality.
    I've attached a spreadsheet with all the test cases I came up with:
    VariableDate_TestCases.xlsx

… null if nthweekday param is invalid.

Began writing tests.
…leDate test cases. To Do: Add GetNextExecution test cases.
…iggerDays setting - updated ShowWhen for backwards compatibility. 3) ToString - updated to provide string representation for variabledate triggers. Schedule - 1) Refactored Triggers_DayOfMonthTrigger to Triggers_DayOfMonthTrigger_SpecificDate, updated fr/fi localized .resxs. 2) Added Triggers_DayOfMonthTrigger_VariableDate string.
@william-deeken
Copy link
Author

william-deeken commented Jul 24, 2025

Has there been any progress on reviewing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant