LWDEV-8274 Use Context in multilimit order #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/SingleLimitOrderPreprocessorTest.kt # src/test/kotlin/com/lykke/matching/engine/utils/MessageBuilder.kt
# Conflicts: # src/dist/cfg/log4j.properties # src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/config/TestExecutionContext.kt # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt
barsukovskii
suggested changes
Apr 15, 2019
src/main/kotlin/com/lykke/matching/engine/daos/context/MultilimitOrderContext.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/incoming/parsers/impl/MultilimitOrderContextParser.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/incoming/parsers/impl/MultilimitOrderContextParser.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/MultilimitOrderPreprocessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/MultilimitOrderPreprocessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt
Outdated
Show resolved
Hide resolved
...lin/com/lykke/matching/engine/incoming/preprocessor/impl/SingleLimitOrderPreprocessorTest.kt
Show resolved
Hide resolved
src/test/kotlin/com/lykke/matching/engine/services/ClientMultiLimitOrderTest.kt
Show resolved
Hide resolved
barsukovskii
suggested changes
Apr 15, 2019
| return true | ||
| } | ||
|
|
||
| fun writeResponse(messageWrapper: MessageWrapper, assetPairId: String, status: MessageStatus, message: String? = null) { |
Contributor
There was a problem hiding this comment.
It is needed to override parrent writeResponse because it is invoked from the parent class and MultiOrderResponse must be returned always (I think it is not a problem not to return assetPairId in those invokes)
| @RunWith(SpringRunner::class) | ||
| @SpringBootTest(classes = [(TestApplicationContext::class)]) | ||
| @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD) | ||
| class MultilimitOrerPreprocessorTest: AbstractTest() { |
|
|
||
| val fatallyInvalidValidationResult = validationResult.values.find { it.isFatalInvalid } | ||
| if (fatallyInvalidValidationResult != null) { | ||
| logger.error("Fatal validation error occurred, ${fatallyInvalidValidationResult.message} " + |
Contributor
There was a problem hiding this comment.
Currently this log is still not displayed properly due to context.multiLimitOrder.orders
# Conflicts: # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt
# Conflicts: # src/test/kotlin/com/lykke/matching/engine/services/LimitOrderMassCancelServiceTest.kt
# Conflicts: # src/main/kotlin/com/lykke/matching/engine/services/validators/business/impl/LimitOrderBusinessValidatorImpl.kt # src/main/kotlin/com/lykke/matching/engine/services/validators/business/impl/StopOrderBusinessValidatorImpl.kt # src/main/kotlin/com/lykke/matching/engine/services/validators/common/OrderValidationUtils.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt # src/test/kotlin/com/lykke/matching/engine/services/validator/business/LimitOrderBusinessValidatorTest.kt # src/test/kotlin/com/lykke/matching/engine/utils/MessageBuilder.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.