rule: intern fields and store them in a tree matching the rule structure. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAD97
approved these changes
Jul 27, 2019
Contributor
CAD97
left a comment
CAD97
left a comment
There was a problem hiding this comment.
This definitely feels better to me.
eddyb
commented
Aug 27, 2019
| let field_rule = |rule, i| RuleWithFields { | ||
| rule, | ||
| fields: self.filter_fields(Some(i)).collect(), | ||
| fields: aggregate_fields |
Contributor
Author
There was a problem hiding this comment.
This closure could be named child and aggregate_fields could be named children.
Contributor
Author
|
I was able to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring a better API for #10 I realized the path trick, as useful as it is otherwise, was holding me back, because it makes recursing on a rule/parse forest, while keeping track of fields, expensive.
You can already see an improvement in the
FolderAPI, for example.I'll update #10 to use this next, possibly a good idea to wait for that before merging.