[SDL-0117] Configurable time before shutdown#129
[SDL-0117] Configurable time before shutdown#129dboltovskyi wants to merge 2 commits intodevelopfrom
Conversation
| common.Title("Test") | ||
| common.Step("Start SDL, init HMI", common.start) | ||
| common.Step("Ignition Off", common.ignitionOff, { 10 }) | ||
| common.Step("Check SDL log is not complete", common.checkSDLLog, { common.logNotComplete }) |
There was a problem hiding this comment.
what's the average time used to write all sdl logs to slow drive for the special test case of send shutdown right after starting SDL?
basically, why choose 10 second in the test and it guarantees 10s is not enough time to write all sdl logs? will 15 or 20 second also makes the test case run successfully?
There was a problem hiding this comment.
@yang1070
Current approach implemented in LuxoftSDL/sdl_atf#8 allows to have all SDL logs saved successfully within 15-20 sec. and not less. This range is pretty stable on a different environments.
| -- In case: | ||
| -- 1. In SDL .ini 'FlushLogMessagesBeforeShutdown' = true and 'MaxTimeBeforeShutdown' = 60 | ||
| -- 2. HMI sends 'BC.OnExitAllApplications(IGNITION_OFF)' notification to SDL | ||
| -- SDL does: |
There was a problem hiding this comment.
is it possible that sdl takes more than 60 seconds to flush all logs, so it stops at 60 seconds and there are still more logs not written?
There was a problem hiding this comment.
@yang1070
ATF approach in LuxoftSDL/sdl_atf#8 allows to have quite stable write speed. The value is defined in https://github.com/LuxoftSDL/sdl_atf/blob/6e61fb28bec35b228ed9c01eb1170be097e95b27/atf_parallels/loop.sh#L18
If this value is decreased SDL would require more time to flush all logs and vise versa: if the value is increased SDL would require less time.
Current values: write speed in ATF and timeouts in scripts was found during experiments.
ATF Test Scripts to check SDL-0117 Configurable time before shutdown feature (and corresponding issue in core:
https://github.com/smartdevicelink/sdl_core/issues/1941)This PR is [not ready] for review.
Summary
New scripts to verify feature
ATF version
Slow drive support
Changelog
Notes
CLA