Skip to content

Comments

[SDL-0117] Configurable time before shutdown#129

Open
dboltovskyi wants to merge 2 commits intodevelopfrom
feature/sdl_0117_configurable_time_before_shutdown
Open

[SDL-0117] Configurable time before shutdown#129
dboltovskyi wants to merge 2 commits intodevelopfrom
feature/sdl_0117_configurable_time_before_shutdown

Conversation

@dboltovskyi
Copy link

@dboltovskyi dboltovskyi commented Jul 19, 2021

ATF Test Scripts to check SDL-0117 Configurable time before shutdown feature (and corresponding issue in core: https://github.com/smartdevicelink/sdl_core/issues/1941)

This PR is [not ready] for review.

Summary

New scripts to verify feature

ATF version

Slow drive support

Changelog

  • Added new scripts for feature
  • Added new test set

Notes

  • Since these scripts require specific version of ATF they can't considered as part of regression scope, and hence merged into develop;
  • It can be used for now for testing purposes of a particular feature;
  • Appropriate changes in ATF (published in PR#8) may be extended and to be delivered as a feature;
  • After that scripts can be merged and included into regression scope.

CLA

common.Title("Test")
common.Step("Start SDL, init HMI", common.start)
common.Step("Ignition Off", common.ignitionOff, { 10 })
common.Step("Check SDL log is not complete", common.checkSDLLog, { common.logNotComplete })

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the average time used to write all sdl logs to slow drive for the special test case of send shutdown right after starting SDL?
basically, why choose 10 second in the test and it guarantees 10s is not enough time to write all sdl logs? will 15 or 20 second also makes the test case run successfully?

Copy link
Author

@dboltovskyi dboltovskyi Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070
Current approach implemented in LuxoftSDL/sdl_atf#8 allows to have all SDL logs saved successfully within 15-20 sec. and not less. This range is pretty stable on a different environments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understand

-- In case:
-- 1. In SDL .ini 'FlushLogMessagesBeforeShutdown' = true and 'MaxTimeBeforeShutdown' = 60
-- 2. HMI sends 'BC.OnExitAllApplications(IGNITION_OFF)' notification to SDL
-- SDL does:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible that sdl takes more than 60 seconds to flush all logs, so it stops at 60 seconds and there are still more logs not written?

Copy link
Author

@dboltovskyi dboltovskyi Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070
ATF approach in LuxoftSDL/sdl_atf#8 allows to have quite stable write speed. The value is defined in https://github.com/LuxoftSDL/sdl_atf/blob/6e61fb28bec35b228ed9c01eb1170be097e95b27/atf_parallels/loop.sh#L18
If this value is decreased SDL would require more time to flush all logs and vise versa: if the value is increased SDL would require less time.

Current values: write speed in ATF and timeouts in scripts was found during experiments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi got it. Thank you.

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants