Feature/sdl 0238 keyboard enhancements revision#103
Open
dboltovskyi wants to merge 7 commits intofeature/sdl_0238_keyboard_enhancementsfrom
Open
Feature/sdl 0238 keyboard enhancements revision#103dboltovskyi wants to merge 7 commits intofeature/sdl_0238_keyboard_enhancementsfrom
dboltovskyi wants to merge 7 commits intofeature/sdl_0238_keyboard_enhancementsfrom
Conversation
dboltovskyi
force-pushed
the
feature/sdl_0238_keyboard_enhancements_revision
branch
from
8357975 to
e2f6348
Compare
dboltovskyi
commented
Feb 5, 2021
| ./test_scripts/API/KeyboardEnhancements/Resumption/002_SDL_resumes_cached_KeyboardProperties.lua | ||
| ./test_scripts/API/KeyboardEnhancements/Resumption/003_SDL_resumes_cached_KeyboardProperties_with_removed_autoCompleteList.lua | ||
| ./test_scripts/API/KeyboardEnhancements/Resumption/004_SDL_resumes_cached_KeyboardProperties_single_parameter.lua | ||
| ./test_scripts/API/KeyboardEnhancements/Resumption/005_SDL_resumes_KeyboardProperties_single_parameter.lua |
Author
There was a problem hiding this comment.
Scripts needs to be renamed: customizeKeys => customKeys
| [05] = { supportedKeyboards = { { keyboardLayout = "QWERTY", numConfigurableKeys = nil }} }, | ||
| [06] = { supportedKeyboards = { { keyboardLayout = nil, numConfigurableKeys = 0 }} }, | ||
| [07] = { supportedKeyboards = common.getArrayValue({ { keyboardLayout = "QWERTY", numConfigurableKeys = 0 }}, 1001) }, | ||
| [08] = { supportedKeyboards = { { keyboardLayout = "QWERTY", numConfigurableKeys = 11 }} } |
Author
There was a problem hiding this comment.
I would add empty array case
| [01] = { customizeKeys = { } }, -- lower out of bound | ||
| [02] = { customizeKeys = common.getArrayValue(keys, 11) }, -- upper out of bound | ||
| [03] = { customizeKeys = 123 }, -- invalid type | ||
| [01] = { customKeys = { } }, -- lower out of bound |
Author
There was a problem hiding this comment.
We need to use EMPTY_ARRAY const for this case
| m.getHMIConnection():ExpectNotification("BasicCommunication.OnAppRegistered") | ||
| :Do(function() | ||
| local dataToHMI = m.cloneTable(pResumptionParams) | ||
| m.getHMIConnection():ExpectRequest("UI.SetGlobalProperties", dataToHMI) |
Author
There was a problem hiding this comment.
Suppose we need to remove dataToHMI here since we have specific ValidIf . Otherwise we'll have double validation.
| keyboardProperties = { | ||
| language = "EN-US", | ||
| keyboardLayout = "AZERTY", | ||
| autoCompleteList = { "Daemon, Freedom" } |
Author
There was a problem hiding this comment.
Propose to use values from sgpParams_1 in order to have more visibility that values are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for
https://github.com/smartdevicelink/sdl_evolution/pull/1117This PR is [ready / not ready] for review.
Summary
Various updates for revision
ATF version
develop
Changelog
CLA