Guard against secret values, remove deprecated UnitBuff#36
Open
Shushuda wants to merge 3 commits intoLudiusMaximus:masterfrom
Open
Guard against secret values, remove deprecated UnitBuff#36Shushuda wants to merge 3 commits intoLudiusMaximus:masterfrom
Shushuda wants to merge 3 commits intoLudiusMaximus:masterfrom
Conversation
This introduces a regression for Demon Hunter's Metamorphosis in combat. It needs to be rewritten to detect model changes instead of aura changes as those are not secret in Midnight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against secret values introduced in Midnight.
Remove deprecated UnitBuff (replaced by C_UnitAuras.GetBuffDataByIndex).
Fix Travel Form exit to normal form resetting offset to 0 due to a timing issue.
This fixes Lua errors in combat that were tainting other addons to the point of breaking them beyond recovery.
This change introduces a regression for Demon Hunter's Metamorphosis detection in combat - no longer possible as-is since it's currently based on aura detection. SpellID is now a secret value in combat. It needs to be rewritten to detect model changes instead of aura changes as those are thankfully still not secret in Midnight. I am trying to figure a fix for this for a separate PR.
Fixes #35