Fix year filter incorrectly showing transactions from all years #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Year filter in ledger view was displaying transactions from all years even when a specific year was selected. Root cause: statement dividers for credit card accounts were created without respecting the year filter, causing year groups to be rendered for non-selected years.
Changes
selectedYeartogroupedDatauseMemo dependency arrayTechnical Context
The
groupedDatamemo iterates through account statements to insert dividers. Previously, it processed all statements regardless ofselectedYear, creating year groups in the grouped data structure even for filtered-out years. When rendered,Object.keys(groupedData)would include these unfiltered years.The fix ensures statement dividers are only created for the selected year, preventing year groups from being added to
groupedDatafor non-matching years.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.