Add new USB command to reset settings to defaults, clean up compiler warnings #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 27, 2025 00:11
Best practice to do versioning inside git rather than leave a trail of old version. Also best practice to move artifacts to releases rather than keep them tracked inside the repo.
Owner
|
I don't see compiler warnings, so not sure what that one is about. |
LowPowerLab
reviewed
Feb 6, 2025
| Serial.println("AUTOOFF_DEFAULT"); | ||
|
|
||
| TOUCH_DEBUG_ENABLED = false; | ||
| Serial.println("TOUCH_DEBUG_DISABLED"); |
Owner
There was a problem hiding this comment.
This is repeated on line 434-435.
LowPowerLab
reviewed
Feb 6, 2025
|
|
||
| LOGGING_FORMAT=LOGGING_FORMAT_EXPONENT; | ||
| eeprom_LOGGINGFORMAT.write(LOGGING_FORMAT); | ||
| Serial.println("LOGGING_FORMAT_EXPONENT"); |
Owner
There was a problem hiding this comment.
This is repeated on lines 430-432.
LowPowerLab
reviewed
Feb 6, 2025
Owner
There was a problem hiding this comment.
This is needed for older versions.
LowPowerLab
reviewed
Feb 6, 2025
Owner
There was a problem hiding this comment.
This is needed for older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new USB interface command
!that resets all runtime settings to default variables. Does not change the calibration values.This makes automation much easier because can easily put the CurrentRanger into a known state. This makes it possible to, say, blindly send the string "!a34fu" and the CurrentRanger will reliably start streaming nanoamp values in the nanoamp format with BIAS disabled and LPF enabled. I do not think there is a way to do ths robustly with the previous firmware.
Also fixes up the three trivial compiler warnings by adding some parenthesis and adding a typecast.
Note that I have only updated the source code file and not the firmware image in this PR. Since these images are artifacts, I'd recommend moving them out of the repo entirely, and instead putting them into releases. LMK if you want more info on why this is the prefered approach or how to do it.