Fixed trailing whitespace #541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the codebase has a lot of trailing whitespace characters. As I started making other changes for potential PRs, I noticed my editor would auto fix them and this would show up in diffs, making it difficult to pick out the actual code changes.
In this PR, I went through all the (not unmaintained) files, simply saved them once and let my editor (Zed) automatically clean up trailing whitespace, weird newlines and ensure each files end with an empty line consistently.
If this PR is merged, all future PRs should be a bit cleaner. On GitHub, you can set the diff viewer to ignore whitespace-only changes by attaching
&w=1to the URL, which should help with review. For some reason,waterpaint.glslseems to throw the diff viewer off, but as far as I can tell, there's nothing interesting that has changed there.It would be nice to have some sort of linter hooked up that would enforce this across editors and contributors, but I don't know what the best way to implement that would be.