[added] pipeline linter #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces automated code linting for the Django project by adding a GitHub Actions workflow. The workflow runs on pull requests to ensure code quality and consistency using the Ruff linter.
- Adds GitHub Actions workflow for automated linting on pull requests
- Configures Python 3.12 environment with Ruff linter
- Sets up basic linting pipeline to check entire codebase
.github/workflows/django-linter.yml
Outdated
|
|
||
| - name: Run linter | ||
| run: | | ||
| ruff check . |
There was a problem hiding this comment.
Consider adding configuration for Ruff's output format and failure behavior. Add '--output-format=github' for better CI integration and ensure the step fails on linting errors.
Suggested change
| ruff check . | |
| ruff check . --output-format=github |
.github/workflows/django-linter.yml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install ruff |
There was a problem hiding this comment.
Consider pinning the Ruff version to ensure consistent linting results across different environments and prevent potential issues from automatic updates.
Suggested change
| pip install ruff | |
| pip install ruff==0.0.285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.