Skip to content

LF-5124 Remove the ability to set an hourly wage from the task flows #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kathyavini wants to merge 18 commits into
base: integration
Choose a base branch
from
Draft

LF-5124 Remove the ability to set an hourly wage from the task flows #4006

kathyavini wants to merge 18 commits into from
+304 −291

Conversation

@kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Jan 24, 2026 •
edited
Loading

Description

Description forthcoming...

Jira link: https://lite-farm.atlassian.net/browse/LF-5124

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini
LF-5124 Deprecate the two sagas associated with userFarm wage and 'do…
5551ab0 
… not ask again'
@kathyavini
LF-5124 First pass of UI update; remove saga handlers; add info for h…
681d0f1 
…ourly wage
@kathyavini
LF-5124 Remove contentForWorkerWithWage logic and update use of overr…
93f9518 
…ide_hourly_wage

override_hourly_wage was saved in the database entry for the task but never read again by the frontend; I'm assuming this was unintentional?
@kathyavini kathyavini self-assigned this Jan 24, 2026
@kathyavini kathyavini force-pushed the LF-5124-remove-the-ability-to-set-an-hourly-wage-from-the-task-flows branch from 67f4745 to 93f9518 Compare January 24, 2026 00:15
@kathyavini
LF-5124 Allow also setting override_hourly_wage to false from the fro…
a3fdb7a 
…ntend

This should complete the missing frontend <--> backend communication around override_hourly_wage and the wage override
@kathyavini
LF-5124 Update strings
cbae410
@kathyavini
LF-5124 Restore the prepopulation logic
b5fd963
@kathyavini
LF-5124 Remove setting wage_at_moment to the user's wage; simplify / …
bc9c10a 
…restore controller return

wage_at_moment null is actually the correct value until task completion if override_hourly_wage is false
@kathyavini
LF-5124 Update Patch task wage tests
f771849
@kathyavini
LF-5124 Complete moving to useCurrencySymbol
2bfd213 
The other grabCurrencySymbol is marked deprecated
@kathyavini kathyavini added enhancement New feature or request new translations New translations to be sent to CrowdIn are present labels Jan 27, 2026
@kathyavini kathyavini requested a review from SayakaOno January 29, 2026 22:09
kathyavini
kathyavini commented Jan 29, 2026
View reviewed changes
packages/api/src/controllers/taskController.js
try {
const irrigationTaskTypes =
await IrrigationTypesModel.getAllIrrigationTaskTypesByFarmId(farm_id);
const irrigationTaskTypes = await IrrigationTypesModel.getAllIrrigationTaskTypesByFarmId(
Copy link
Collaborator Author

@kathyavini kathyavini Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the diff immediately below are precommit linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SayakaOno SayakaOno Awaiting requested review from SayakaOno

At least 1 approving review is required to merge this pull request.

Assignees

@kathyavini kathyavini

Labels

enhancement New feature or request new translations New translations to be sent to CrowdIn are present

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kathyavini