LF-5111 Replace useMemo with other hooks #3997
Draft
+34
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The branch
tests/useref_for_surveyis an exploration of react hooks This PR is the result of that.We want to:
useMemo is appropriate for cases where there are expensive computations. A class instantiation could be considered an expensive computation. But it is not necessary to achieve a single instance instantiation.
useRef is appropriate for cases where we want a really stable reference to something that we do not expect to need to re-render based on that reference.
The example shown in tech-daily for useRef was for the case where surveyJson is not expected to change within the component lifecycle. So changing that prop would have no effect. Something the useMemo version had that the useRef example did not.
Notes
Jira link:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
pnpm i18nto help with this)