Skip to content

Code challenge 1 - render_cb#1

Open
LisaCee wants to merge 1 commit intodevelopfrom
render_cb
Open

Code challenge 1 - render_cb#1
LisaCee wants to merge 1 commit intodevelopfrom
render_cb

Conversation

@LisaCee
Copy link
Owner

@LisaCee LisaCee commented Nov 15, 2021

Here are the changes that I made to the render_cb function

  • fix two undefined index variables
  • corrected linting errors
  • escape all content for security
  • escaping for concatenated mixed content

I misunderstood that you wanted me to create a PR to my own copy of the repo. I had mistakenly made my changes to the develop branch and then there were no changes to create a PR against. If you could like to see my complete git history of contributions, please check out this repo.

fix two undefined index variables

corrected linting errors

escape all content for security

excaping for contatenated mixed content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant