feat/upload #46
Draft
feat/upload #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holoflins
reviewed
Dec 3, 2019
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'mysql', 'Migration can only be executed safely on \'mysql\'.'); | ||
|
|
||
| $this->addSql('DROP TABLE customer'); |
Contributor
There was a problem hiding this comment.
il faudra que tu rebase ta table pour ne pas garder customer dans ta migration
| { | ||
| private $targetDirectory; | ||
|
|
||
| // public function __construct($targetDirectory) |
Contributor
There was a problem hiding this comment.
ne merge jamais de code commenté. Si tu n'as pas besoin de se bout de code tu le vire. Si tu n'en as pas besoin dans cette PR, tu le fais dans une pr distincte. 90% du code commenté reste du code mort
| // //$this->targetDirectory = $targetDirectory; | ||
| // } | ||
|
|
||
| public function upload(UploadedFile $file) |
| ); | ||
| $fileName = $safeFilename.'-'.uniqid().'.'.$file->guessExtension(); | ||
|
|
||
| try { |
Contributor
There was a problem hiding this comment.
ta méthode ne va pas car tu retourne soit ton $fileName, soit void. Dans ton cas, je retournerais toujours une string soit le filename, soit ''.
Du coup tu peux virer ton try catch qui ne te sert pas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.